Attempt to fix occasional CI client/server test flakes. #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The success-case `print` for the `wait_tcp_port` helper wasn't
formatting its message as an f-string, instead printing the literal
`{host}` and `{port}` placeholders.
The `run_mtls_client_tests` and `run_mtls_client_crl_tests` were being run without calling `wait_tcp_port` first. I suspect this is the reason we sometimes see the connect tests fail in CI on some platforms with output about the connection being refused.
jsha
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
This looks good, thanks!
Based on #337 (comment), I suspect we may also wind up needing to randomize port number on a per-testcase basis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch attempts to resolve #336. I say "attempts" because I've had little luck trying to force the flake to happen in CI (even when hacking up the build tasks to just run multiple instances of the Windows/MacOS tests that seem to catch the flake most often).
I think this is the most obvious reason why we'd see the flakes we see, but it's hard to say conclusively :-)
tests: fix wait_tcp_port format string.
The success-case
printfor thewait_tcp_porthelper wasn't formatting its message as an f-string, instead printing the literal{host}and{port}placeholders.tests: wait for tcp port for all test types.
The
run_mtls_client_testsandrun_mtls_client_crl_testswere being run without callingwait_tcp_portfirst. I suspect this is the reason we sometimes see the connect tests fail in CI on some platforms with output about the connection being refused.