Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If ACLs are disabled, it should not require the file to exist #60

Closed
ogarcia opened this issue Nov 14, 2024 · 3 comments
Closed

If ACLs are disabled, it should not require the file to exist #60

ogarcia opened this issue Nov 14, 2024 · 3 comments
Assignees
Labels
A-authentication Area: Related to ACL and Htpasswd A-config Area: Related to the config file functionality and format A-ui-ux Area: Related to user interfaces and user experience C-bug Category: Something isn't working as expected
Milestone

Comments

@ogarcia
Copy link

ogarcia commented Nov 14, 2024

Let's take this configuration as an example:

[acl]
acl-path = "/test_data/test_repo/acl.toml"
private-repo = false
append-only = false

Since I have private-repo set to false it should not even access the ACL file. However when I run the application it gives an error:

% ./rustic-server -c rustic-server.toml serve
error: storage error: Could not create ACL due to Internal server error: `Could not read toml file: No such file or directory (os error 2) at "/etc/rustic-server/acl.toml"`

On the other hand I think it is more descriptive to use a disable-acl key (in the style of disable-auth) than private-repo.

@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Nov 14, 2024
@simonsan simonsan added A-config Area: Related to the config file functionality and format A-ui-ux Area: Related to user interfaces and user experience C-bug Category: Something isn't working as expected A-authentication Area: Related to ACL and Htpasswd and removed S-triage Status: Waiting for a maintainer to triage this issue/PR labels Nov 15, 2024
@simonsan simonsan self-assigned this Nov 15, 2024
@simonsan
Copy link
Contributor

I'm currently working on refactoring some more things, so it's easier to transition into a runtime context after parsing and loading the config. This will be fixed with the next release. 👍🏽

@simonsan simonsan added this to the NEXT milestone Nov 15, 2024
@simonsan
Copy link
Contributor

This should be fixed in the new release: https://github.com/rustic-rs/rustic_server/releases/tag/v0.3.0

Please reopen, if that is not the case. 👍🏽

@ogarcia
Copy link
Author

ogarcia commented Nov 16, 2024

It works perfectly, thank you very much!

BTW, I maintain the rustic-server package in the AUR, anything weird you see or would like to change, feel free to tell me about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-authentication Area: Related to ACL and Htpasswd A-config Area: Related to the config file functionality and format A-ui-ux Area: Related to user interfaces and user experience C-bug Category: Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants