Simplify + cleanup running destructors #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-h-chamberlain
requested review from
a team,
AzureMarker,
FenrirWolf and
Meziu
We can keep the loop basically how it was before and avoid the extra Vec collection, as long as we drop the write lock before calling the destructor.
ian-h-chamberlain
force-pushed
the
fix/collect-destructors
branch
from
7fec966 to
0e6f793
Compare
Meziu
approved these changes
May 17, 2024
There was a problem hiding this comment.
Great, less allocations is less time wasted on a thread's exit routine. I am still a bit unsure whether everything will work just fine, since there isn't the lock assuring wrongdoings with the local keys, but unlocking is necessary to avoid the deadlock, so there's not much we can do.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #31
We can keep the loop basically how it was before and avoid the extra Vec collection, as long as we drop the write lock before calling the destructor.
I think this code looks a bit cleaner/simpler too.