Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect destructors, then run them to release lock #31

Merged
merged 1 commit into from
May 12, 2024

Conversation

ian-h-chamberlain
Copy link
Member

Fixes #30

From what I can tell, some destructor that Rust registers ends up trying to modify or read KEYS as well, so we end up deadlocking because the lock was already held when we call that destructor.

I also made a change to set the args to null so we don't end up with lingering references to destructor args after running the destructor.

@ian-h-chamberlain ian-h-chamberlain requested review from a team, AzureMarker, FenrirWolf and Meziu May 12, 2024 20:35
Copy link
Member

@Meziu Meziu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems exactly as you had proposed. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent changes seem to cause a deadlock when thread spawns
2 participants