Generate bindings with build.rs at compile time #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effectively: - Move the previous bindgen script into build.rs - In lib.rs, include the file generated at build time - Compile inline statics with devkitARM toolchain - Remove now-unneeded reimplementations of inline statics - Use doxygen_rs to clean up the docs of the generated bindings. Nice! This cleans up the repo a lot and also ensures we are using the canonical implementations of those inline functions, which should help prevent mistakes as well.
Assume devkitARM ships with only a single version, so then find the
first entry matching `${DEVKITARM}/lib/gcc/arm-none-eabi/*/include` and add it
to the -isystem includes.
Meziu
approved these changes
Oct 1, 2023
This was referenced Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @FenrirWolf for doing a bunch of awesome work in rust3ds/ctru-rs#133 which paved the way for this PR! (I basically just copy-pasted their implementation of the
cccompile steps)Effectively:
This cleans up the repo a lot and also ensures we are using the
canonical implementations of those inline functions, which should help
prevent mistakes in those as well.
Also, in #25 I forgot to hook up the
test_runner::run_gdbitself, so that should be fixed now. We didn't have any tests for it to matter yet so no biggie.