Window::set_minimized (#985) #990

SuperiorJT · 2019-06-27T01:12:16Z

Gets started on supporting Window::set_minimized (#985, #983). I'm very new to this repo and a beginner in Rust so it might not be exactly how you guys want it. I've tested it on macOS via keyboard events and was able to make it minimize similar to other macOS applications. I'm willing to work on the Windows side of this as well.

src/platform_impl/linux/wayland/window.rs

Co-Authored-By: Victor Berger <[email protected]>

SuperiorJT · 2019-06-27T16:17:13Z

On the Windows implementation do we want to create a WindowFlag for MINIMIZED? I'm looking at the way set_maximized works and it looks like we could do something similar, but I don't know if we should track that in our WindowState.

Osspial · 2019-06-28T18:11:26Z

@SuperiorJT We should track that in WindowFlags, yeah.

…to set-minimize

goddessfreya · 2019-09-23T05:08:17Z

@SuperiorJT What is the status on this PR?

SuperiorJT · 2019-09-25T16:45:51Z

Implementations are made for windows, macOS and wayland. We need someone to develop the x11 and iOS (if applicable) implementation since I am unable to. Once all is implemented, then I can go through and fmt and update required documentation.

murarth · 2019-09-25T18:00:01Z

I have an implementation for X11 ready: https://github.com/murarth/winit/tree/x11-set-minimize

# Conflicts: # src/platform_impl/emscripten/mod.rs # src/platform_impl/linux/mod.rs # src/platform_impl/windows/event_loop.rs

SuperiorJT · 2019-09-27T14:16:36Z

I added @murarth's X11 implementation, formatted, and added documentation. It's ready for review.

murarth · 2019-10-02T19:49:50Z

src/platform_impl/android/mod.rs

+    pub fn set_minimized(&self, _minimized: bool) {
+        unimplemented!()
+    }


Do we want this to panic or should it be a no-op? set_maximized below is a no-op.

I don't think it particularly matters, since the Android backend doesn't even compile right now.

Osspial · 2019-10-17T00:03:35Z

I've tested this out on Windows, and this seems to cause glitches if you do the following:

Maximize the window
Minimize the window via set_minimized
Alt-tab back into the window

If you do that, the minimize button in the window's titlebar has the window restore icon instead of the window minimize icon, and fails to minimize the window when pressed.

vbogaevsky

Works smoothly on macOS

# Conflicts: # FEATURES.md

SuperiorJT · 2019-11-06T02:58:30Z

I've fixed the maximize issue. Windows didn't like the window styles being set after minimization. Let me know if you find any more issues.

goddessfreya

It no-op'd as expected with i3, which doesn't support minimizing. I'm going to kick the bucket to @murarth who I'm guessing has a gnome/KDE/etc setup lying around.

murarth · 2019-11-22T21:15:44Z

@goddessfreya I wrote the X11 implementation myself, so I can confirm it works. If we want to ping our X11 testers to get another set of eyes on it, that's fine by me.

goddessfreya · 2019-11-22T21:28:49Z

@murarth Haha, I'm ever so slightly blind. I see. Did you test for weird behavior evolving fullscreened/unmapped windows? Should be good to go on the X11 side, I don't see much that could go wrong.

murarth · 2019-11-22T23:48:31Z

@goddessfreya I've tested for any weird interactions and found none.

Osspial

Windows changes look good. Could you add stub implementations for WASM? Once that's done, this should be good to merge.

SuperiorJT · 2019-12-16T19:16:33Z

I added the stub for WASM. Let me know if I missed anything.

Expose set_minimized. Implement for macOS (rust-windowing#985)

55614c0

SuperiorJT changed the title ~~Expose set_minimized. Implement for macOS (#985)~~ Window::set_minimized (#985) Jun 27, 2019

elinorbgr reviewed Jun 27, 2019

View reviewed changes

src/platform_impl/linux/wayland/window.rs Outdated Show resolved Hide resolved

Implement set_minimized for Wayland (rust-windowing#985)

900e711

Co-Authored-By: Victor Berger <[email protected]>

SuperiorJT added 3 commits June 28, 2019 16:10

Implement set_minimized for Windows (rust-windowing#985)

b7d0c16

Merge branch 'set-minimize' of https://github.com/SuperiorJT/winit in…

fdf4efe

…to set-minimize

Remove debug logs (rust-windowing#985)

149594b

Implement Window::set_minimized for X11

7b8b93d

SuperiorJT and others added 8 commits September 26, 2019 21:33

Merge branch 'master' into set-minimize

78b247d

# Conflicts: # src/platform_impl/emscripten/mod.rs # src/platform_impl/linux/mod.rs # src/platform_impl/windows/event_loop.rs

Remove extra param from set_window_flags call

71fe55a

Cargo fmt

31c2e4b

Add example of usage

c3c787a

Update changelog

f6826dd

Update feature matrix

f74072b

Cargo fmt

3e4ca2e

Update example to remove unnecessary event var

2927006

murarth reviewed Oct 2, 2019

View reviewed changes

vbogaevsky approved these changes Oct 19, 2019

View reviewed changes

SuperiorJT added 2 commits November 5, 2019 21:45

Stop setting window styles when minimizing (rust-windowing#985)

f118870

Merge remote-tracking branch 'origin/master' into set-minimize

3a529f1

# Conflicts: # FEATURES.md

SuperiorJT requested a review from Osspial November 6, 2019 02:58

Merge branch 'master' into set-minimize

9d875c4

goddessfreya self-requested a review November 11, 2019 22:53

goddessfreya added DS - macos DS - wayland DS - windows DS - x11 C - waiting on maintainer A maintainer must review this code labels Nov 11, 2019

kchibisov mentioned this pull request Nov 22, 2019

⌘+m does not minimize window alacritty/alacritty#2534

Closed

goddessfreya requested review from elinorbgr and murarth November 22, 2019 19:58

goddessfreya approved these changes Nov 22, 2019

View reviewed changes

murarth approved these changes Nov 22, 2019

View reviewed changes

elinorbgr approved these changes Nov 24, 2019

View reviewed changes

Osspial approved these changes Nov 27, 2019

View reviewed changes

SuperiorJT added 2 commits December 16, 2019 14:09

Merge remote-tracking branch 'origin/master' into set-minimize

db3d6d4

Add stub for WASM (rust-windowing#985)

b96e415

Merge branch 'master' into set-minimize

60d5a89

Osspial merged commit 82889e2 into rust-windowing:master Dec 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Window::set_minimized (#985) #990

Window::set_minimized (#985) #990

SuperiorJT commented Jun 27, 2019 •

edited

Loading

SuperiorJT commented Jun 27, 2019

Osspial commented Jun 28, 2019

goddessfreya commented Sep 23, 2019

SuperiorJT commented Sep 25, 2019

murarth commented Sep 25, 2019

SuperiorJT commented Sep 27, 2019

murarth Oct 2, 2019

Osspial Oct 16, 2019 •

edited

Loading

Osspial commented Oct 17, 2019

vbogaevsky left a comment

SuperiorJT commented Nov 6, 2019

goddessfreya left a comment

murarth commented Nov 22, 2019

goddessfreya commented Nov 22, 2019

murarth commented Nov 22, 2019

Osspial left a comment

SuperiorJT commented Dec 16, 2019

Window::set_minimized (#985) #990

Window::set_minimized (#985) #990

Conversation

SuperiorJT commented Jun 27, 2019 • edited Loading

SuperiorJT commented Jun 27, 2019

Osspial commented Jun 28, 2019

goddessfreya commented Sep 23, 2019

SuperiorJT commented Sep 25, 2019

murarth commented Sep 25, 2019

SuperiorJT commented Sep 27, 2019

murarth Oct 2, 2019

Choose a reason for hiding this comment

Osspial Oct 16, 2019 • edited Loading

Choose a reason for hiding this comment

Osspial commented Oct 17, 2019

vbogaevsky left a comment

Choose a reason for hiding this comment

SuperiorJT commented Nov 6, 2019

goddessfreya left a comment

Choose a reason for hiding this comment

murarth commented Nov 22, 2019

goddessfreya commented Nov 22, 2019

murarth commented Nov 22, 2019

Osspial left a comment

Choose a reason for hiding this comment

SuperiorJT commented Dec 16, 2019

SuperiorJT commented Jun 27, 2019 •

edited

Loading

Osspial Oct 16, 2019 •

edited

Loading