Prevent the event loop from pausing when entering modal loop (eventloop-2.0) #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After clicking the window title bar or border (for a drag or resize), the event loop pauses until the mouse is moved. This change relays the WM_NCLBUTTONDOWN message to the dummy window where it queues a redraw and consumes the message. This effectively jumpstarts the modal loop and it continues to fire draw requests.
aloucks
changed the title
aloucks
changed the title
Osspial
reviewed
Apr 13, 2019
| } | ||
| drop(runner); | ||
| commctrl::DefSubclassProc(window, msg, wparam, lparam) | ||
| }, |
There was a problem hiding this comment.
Why do you forward the WM_NCLBUTTONDOWN message to the dummy window and trigger a redraw in there, instead of asking it to redraw directly from here?
There was a problem hiding this comment.
I checked again and also came to the conclusion that it's not necessary. I've pushed a new commit to remove the forwarding. I think it was leftover from sorting out the relationship with the dummy modal window.
Relaying the WM_NCLBUTTONDOWN message to the modal window turned out to be unnecessary.
felixrabe
pushed a commit
to felixrabe/winit
that referenced
this pull request
Jun 30, 2019
…op-2.0) (rust-windowing#839) * Prevent the event loop from pausing after entering modal loop After clicking the window title bar or border (for a drag or resize), the event loop pauses until the mouse is moved. This change relays the WM_NCLBUTTONDOWN message to the dummy window where it queues a redraw and consumes the message. This effectively jumpstarts the modal loop and it continues to fire draw requests. * Handle WM_NCLBUTTONDOWN in public_window_callback instead of relaying. Relaying the WM_NCLBUTTONDOWN message to the modal window turned out to be unnecessary.
kosyak
pushed a commit
to kosyak/winit
that referenced
this pull request
Jul 10, 2019
…op-2.0) (rust-windowing#839) * Prevent the event loop from pausing after entering modal loop After clicking the window title bar or border (for a drag or resize), the event loop pauses until the mouse is moved. This change relays the WM_NCLBUTTONDOWN message to the dummy window where it queues a redraw and consumes the message. This effectively jumpstarts the modal loop and it continues to fire draw requests. * Handle WM_NCLBUTTONDOWN in public_window_callback instead of relaying. Relaying the WM_NCLBUTTONDOWN message to the modal window turned out to be unnecessary.
8 tasks
aloucks
added a commit
to aloucks/winit
that referenced
this pull request
Feb 23, 2025
When clicking the title bar on Windows, to drag the window, there is a noticible pause in continuous redraw requests. This was fixed in rust-windowing#839 and then regressed in rust-windowing#1852. The cursor blinks in both cases and is unrelated. The regression made the blink happen after the pause instead of immediately.
aloucks
added a commit
to aloucks/winit
that referenced
this pull request
Feb 23, 2025
When clicking the title bar on Windows, to drag the window, there is a noticible pause in continuous redraw requests. This was fixed in rust-windowing#839 and then regressed in rust-windowing#1852. The cursor blinks in both cases and is unrelated. The regression made the blink happen after the pause instead of immediately.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After clicking the window title bar or border (for a drag or resize), the event loop pauses until the mouse is moved. This change relays the
WM_NCLBUTTONDOWNmessage to the dummy window where it queues a redraw and consumes the message. This effectively jumpstarts the modal loop and it continues to fire draw requests.