Partially replace custom AppKit bindings with icrate's autogenerated bindings #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
objc2-new-version
branch
3 times, most recently
from
b7950d4 to
5eafe7b
Compare
madsmtm
force-pushed
the
replace-with-icrate-appkit
branch
from
f8d470b to
bff3e48
Compare
2 tasks
2 tasks
madsmtm
force-pushed
the
replace-with-icrate-appkit
branch
from
bff3e48 to
c5cd797
Compare
madsmtm
force-pushed
the
replace-with-icrate-appkit
branch
from
c5cd797 to
eac5fd1
Compare
madsmtm
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
icratecontains autogenerated bindings to AppKit, we should use those instead of defining the bindings ourselves (which can be very error prone and tedious).Companion PR for making a lot of the
unsafewe use inicratesafe: madsmtm/objc2#475