-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Windows): add skip taskbar methods #2177
feat(Windows): add skip taskbar methods #2177
Conversation
Hello! Thanks for the PR, sorry for the long silence on this topic. |
AFAIK, window styles can't achieve this behavior but I am open to suggestion of what window styles I can look into. Using Anyways, We have been using this in tao for quite some time now, around 6 or 7 months and there was no side effects observed. Even electron is using the same API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I was looking if there was a cheaper option to achieve this with the existing API but I'm fine with the TaskList API as well. (WS_EX_TOOLWINDOW
seems to have some side-effects, the event loop owned window works as well but doesn't allow toggling at runtime). The only smaller issue I found was toggling with borderless will result in always showing the taskbar requiring explicit toggling of borderless to fix it again but that seems rather minor overall.
My only point open would be renaming the functions to set_taskbar
and with_taskbar
, dropping the skip
- fits better to the current API imo.
Never noticed this behavior before in
The name was straight out taken from electron's |
CHANGELOG.md
if knowledge of this change could be valuable to users