android: Use event identifier instead of userdata pointer #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndk-glue currently sets both the `ident` field and user-data pointer to `0` or `1` for the event pipe and input queue respectively, to tell these sources apart. While it works to reinterpret this `data` pointer as integer identifier it shouldn't be abused for that, in particular when one may wish to provide extra information with an event in the future; then the `data` field is used as pointer (or abused as abstract value) for that.
dvc94ch
approved these changes
Jan 13, 2021
8 tasks
MarijnS95
added a commit
to MarijnS95/winit
that referenced
this pull request
Jan 30, 2021
Following the changes in [1] this bumps ndk and ndk-glue to 0.3 and uses the new constants. The minor version has been bumped to prevent applications from running an older winit (without rust-windowing#1826) with a newer ndk/ndk-glue that does not pass this `ident` through the `data` pointer anymore. [1]: rust-mobile/ndk#112
MarijnS95
added a commit
that referenced
this pull request
Jan 30, 2021
…1847) Following the changes in [1] this bumps ndk and ndk-glue to 0.3 and uses the new constants. The minor version has been bumped to prevent applications from running an older winit (without #1826) with a newer ndk/ndk-glue that does not pass this `ident` through the `data` pointer anymore. [1]: rust-mobile/ndk#112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ndk-glue currently sets both the
identfield and user-data pointer to0or1for the event pipe and input queue respectively, to tell these sources apart. While it works to reinterpret thisdatapointer as integer identifier it shouldn't be abused for that, in particular when one may wish to provide extra information with an event in the future; then thedatafield is used as pointer (or abused as abstract value) for that.These constants (
0and1) are internal tondk-glueand not publicly documented anywhere (afaik). I believe they should at least be exposed as constants, or perhaps abstracted behind apollfunction internal tondk-glue. Consequently we might want to warn API users when they try use one of these "reservedidents" (but only on the thread looper set up byndk-gluesinit()function)?CC @dvc94ch @msiglreith
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users