Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Crash on macOS when starting maximized without decorations #1323

Merged
merged 4 commits into from
Dec 20, 2019
Merged

FIX Crash on macOS when starting maximized without decorations #1323

merged 4 commits into from
Dec 20, 2019

Conversation

hatoo
Copy link
Contributor

@hatoo hatoo commented Dec 18, 2019 •
edited
Loading

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

This PR fixes #1288
It was crashed in set_style_mask_sync.
As far as I investigated, dispatch_sync_f must not be called in the main thread, so I added if clause to detect the main thread and call callback directly then.

@goddessfreya goddessfreya added DS - macos C - waiting on maintainer A maintainer must review this code labels Dec 18, 2019
@goddessfreya
Copy link
Contributor

r? @aleksijuvani or @vbogaevsky

@goddessfreya goddessfreya removed the C - waiting on maintainer A maintainer must review this code label Dec 20, 2019
@goddessfreya
Copy link
Contributor

Thanks @aleksijuvani. Will merge when CI completes.

@goddessfreya goddessfreya merged commit 38c8cb9 into rust-windowing:master Dec 20, 2019
jgmize added a commit to jgmize/dotfiles that referenced this pull request Dec 29, 2019
@jgmize
Add decorations: none to .alacritty.yml
0bd4dea 
Cannot yet add startup_mode: Maximized due to jwilm/alacrity#2877
Upstream fix has landed in rust-windowing/winit#1323
jgmize added a commit to jgmize/dotfiles that referenced this pull request Dec 29, 2019
@jgmize
Add decorations: none to .alacritty.yml
a772f08 
Cannot yet add startup_mode: Maximized due to alacritty/alacritty#2877
Upstream fix has landed in rust-windowing/winit#1323
This was referenced Dec 29, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
DS - macos
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on macOS when starting maximized without decorations
2 participants
@hatoo @goddessfreya