Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix run_return in MacOS #1321

Merged
merged 4 commits into from
Dec 19, 2019
Merged

Fix run_return in MacOS #1321

merged 4 commits into from
Dec 19, 2019

Conversation

hatoo
Copy link
Contributor

@hatoo hatoo commented Dec 17, 2019 •
edited
Loading

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

This PR fixes #1242 while keeping #1117 fixed.

According to https://stackoverflow.com/questions/48041279/stopping-the-nsapplication-main-event-loop a UI event must be happening to stop event loop actually.

So I chose to modify the main window's title to activate stop.

@goddessfreya goddessfreya added DS - macos C - waiting on maintainer A maintainer must review this code labels Dec 17, 2019
@goddessfreya
Copy link
Contributor

r? @aleksijuvani or @vbogaevsky

@vbogaevsky vbogaevsky merged commit 01203b2 into rust-windowing:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbogaevsky vbogaevsky vbogaevsky approved these changes

Assignees
No one assigned
Labels
C - waiting on maintainer A maintainer must review this code DS - macos
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOS: run_return terminates an app instead of continuing past return
3 participants
@hatoo @goddessfreya @vbogaevsky