Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventLoopClosed should contain the original event #1292

Closed
fogti opened this issue Nov 27, 2019 · 0 comments · Fixed by #1294
Closed

EventLoopClosed should contain the original event #1292

fogti opened this issue Nov 27, 2019 · 0 comments · Fixed by #1294
Labels
C - needs discussion Direction must be ironed out S - api Design and usability S - enhancement Wouldn't this be the coolest?

Comments

@fogti
Copy link
Contributor

fogti commented Nov 27, 2019 •
edited
Loading

This is a feature request.

Other, more low-level channel-alike crates provide each provide a send method with an Err(...(T)) result for the failure case to recover the original event without a need to clone it before-hand, but winit (as a high-level interface/wrapper) doesn't. I think this is a bit inconsistent. If there are some underlying platform implementations, where this is not possible, I think EventLoopProxy::send_event should return an Option-alike type (or a custom enum) in the error case.

Examples:
@fogti fogti mentioned this issue Nov 27, 2019
Merged
8 tasks
@goddessfreya goddessfreya added C - needs discussion Direction must be ironed out S - api Design and usability S - enhancement Wouldn't this be the coolest? labels Nov 27, 2019
This was referenced Nov 28, 2019
Closed
Merged
murarth pushed a commit that referenced this issue Dec 7, 2019
@fogti @murarth
Have EventLoopClosed contain the original event (#1294)
830d47a 
* Fix issue #1292

* Remove "optionally" from changelog entry
@fogti fogti mentioned this issue Dec 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C - needs discussion Direction must be ironed out S - api Design and usability S - enhancement Wouldn't this be the coolest?
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have EventLoopClosed contain the original event
2 participants
@fogti @goddessfreya