From b513b70a231b3cc07d1f8ecb90e59901d4da5276 Mon Sep 17 00:00:00 2001 From: John Nunley Date: Sun, 3 Mar 2024 10:19:43 -0800 Subject: [PATCH 1/5] msrv: Add MSRV policy regarding wasm-bindgen wasm-bindgen recently bumped its MSRV to v1.73, which is much higher than our MSRV of 1.64. Add an note to the README describing our MSRV policy, and then test for it in CI. Signed-off-by: John Nunley --- .github/workflows/ci.yml | 7 ++++++- README.md | 11 +++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9caf99a..e86d260 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,7 +31,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - rust_version: ["1.64", stable, nightly] + rust_version: ["1.64", "1.73", stable, nightly] steps: - uses: actions/checkout@v2 @@ -51,4 +51,9 @@ jobs: - name: Run tests for wasm32-unknown-unknown run: cargo hack check --target wasm32-unknown-unknown --feature-powerset + if: matrix.rust_version != "1.64" + + - name: Run tests for wasm32-unknown-unknown + run: cargo hack check --target wasm32-unknown-unknown --feature-powerset --skip wasm-bindgen-0-2 + if: matrix.rust_version -= "1.64" diff --git a/README.md b/README.md index bee8061..8ed6e30 100644 --- a/README.md +++ b/README.md @@ -9,3 +9,14 @@ raw window handle and display's platform-specific raw display handle. This does not provide any utilities for creating and managing windows; instead, it provides a common interface that window creation libraries (e.g. Winit, SDL) can use to easily talk with graphics libraries (e.g. gfx-hal). + +## MSRV Policy + +The Minimum Safe Rust Version (MSRV) of this crate as of the time of writing is +**1.64.0**. For pre-`1.0` releases of `raw-window-handle`, this version will not +be changed without a patch bump to the version of `raw-window-handle`. After +version `1.0.0` is released, changes to the MSRV will necessitate a minor +version bump. + +When the `wasm-bindgen-0-2` feature is enabled, the MSRV of this crate will be +raised to the MSRV of the latest version of `wasm-bindgen`. From f1f5c4e648742266165d892a36dfba9b8301b8ee Mon Sep 17 00:00:00 2001 From: John Nunley Date: Sun, 3 Mar 2024 10:22:33 -0800 Subject: [PATCH 2/5] chore: Fix CI Signed-off-by: John Nunley --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e86d260..86f2611 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -51,9 +51,9 @@ jobs: - name: Run tests for wasm32-unknown-unknown run: cargo hack check --target wasm32-unknown-unknown --feature-powerset - if: matrix.rust_version != "1.64" + if: matrix.rust_version != '1.64' - name: Run tests for wasm32-unknown-unknown run: cargo hack check --target wasm32-unknown-unknown --feature-powerset --skip wasm-bindgen-0-2 - if: matrix.rust_version -= "1.64" + if: matrix.rust_version == '1.64' From 7012f857250d1e040cf60d26ee36b1500f25ab8d Mon Sep 17 00:00:00 2001 From: John Nunley Date: Mon, 4 Mar 2024 20:08:05 -0800 Subject: [PATCH 3/5] chore: Fix MSRV via cargo pin Signed-off-by: John Nunley --- .github/workflows/ci.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 86f2611..2a9a7d9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,7 +31,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - rust_version: ["1.64", "1.73", stable, nightly] + rust_version: ["1.64", stable, nightly] steps: - uses: actions/checkout@v2 @@ -41,6 +41,13 @@ jobs: rust-version: ${{ matrix.rust_version }} - run: rustup target add wasm32-unknown-unknown + - name: Pin deps that break MSRV + if: matrix.rust_version == '1.64.0' + run: | + cargo update -p exr --precise 1.71.0 + cargo update -p ahash --precise 0.8.7 + cargo update -p bumpalo --precise 3.14.0 + - name: Check documentation run: cargo doc --no-deps --document-private-items @@ -51,9 +58,3 @@ jobs: - name: Run tests for wasm32-unknown-unknown run: cargo hack check --target wasm32-unknown-unknown --feature-powerset - if: matrix.rust_version != '1.64' - - - name: Run tests for wasm32-unknown-unknown - run: cargo hack check --target wasm32-unknown-unknown --feature-powerset --skip wasm-bindgen-0-2 - if: matrix.rust_version == '1.64' - From 17c9ca4a84c6565f1240f39636c817f291f57d0d Mon Sep 17 00:00:00 2001 From: John Nunley Date: Mon, 4 Mar 2024 20:32:44 -0800 Subject: [PATCH 4/5] chore: Typo fix Signed-off-by: John Nunley --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2a9a7d9..c806c36 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,7 +42,7 @@ jobs: - run: rustup target add wasm32-unknown-unknown - name: Pin deps that break MSRV - if: matrix.rust_version == '1.64.0' + if: matrix.rust_version == '1.64' run: | cargo update -p exr --precise 1.71.0 cargo update -p ahash --precise 0.8.7 From caba343610f2a51afbfd289a2e06199a2fd287e3 Mon Sep 17 00:00:00 2001 From: John Nunley Date: Mon, 4 Mar 2024 20:39:53 -0800 Subject: [PATCH 5/5] ci: Only pin necessary deps Signed-off-by: John Nunley --- .github/workflows/ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c806c36..180d999 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -44,8 +44,6 @@ jobs: - name: Pin deps that break MSRV if: matrix.rust_version == '1.64' run: | - cargo update -p exr --precise 1.71.0 - cargo update -p ahash --precise 0.8.7 cargo update -p bumpalo --precise 3.14.0 - name: Check documentation