-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a more generic parser for command line arguments #55
Comments
Could you please assign this to me? |
@FedericoPonzi done! Happy coding! |
Related: I am thinking whether it's a good idea to use So the code would look like - let vmm_cfg = VMMConfig::builder()
.memory(...)
.kernel(...)
.net(...) And with right set of defaults, so not everything becomes a required config? |
I personally like the builder pattern, I wonder how much it helps in this scenario. A prototype would be nice.
Besides the kernel path, for everything else we can have defaults. @gabhijit are you interested in contributing your proposal? |
@andreeaflorescu , Sure I can give it a try . Let me create a separate issue? |
Yap, sounds good. |
We currently duplicate the parsing logic in the
try_from
functions ofMemoryConfig
,VcpuConfig
,KernelConfig
,NetConfig
,BlockConfig
. As we add more devices and configuration, this duplication generates too much boilerplate code.We should try to see if we can somehow reduce this duplication (without adding new rust crates dependencies).
The text was updated successfully, but these errors were encountered: