Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate vhost_binding.rs and move custom changes in another file #188

Open
stefano-garzarella opened this issue Sep 15, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@stefano-garzarella
Copy link
Member

In a PR #185, we fixed some new clippy warnings, but there is one related to __IncompleteArrayField that should be auto-generated by bindgen.

We used an old version that generated also Copy/Clone implementations, but now it looks like they removed it: rust-lang/rust-bindgen#1431

@jiangliu agreed on regenerate it with a new version of bindgen.
We also modified a bit the vhost_binding.rs generated file, so it may be better to move the new struct in another file, so we can update it easily next time

@stefano-garzarella stefano-garzarella added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant