Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test_bench] Allow for different names for benchmarks #32

Open
andreeaflorescu opened this issue Aug 10, 2020 · 1 comment
Open

[test_bench] Allow for different names for benchmarks #32

andreeaflorescu opened this issue Aug 10, 2020 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@andreeaflorescu
Copy link
Member

In test_bench, we now expect all benchmarks to be named main. This is because we are running the benchmarks as follows:
cargo bench --bench main --all-features -- --noplot --save-baseline {}.

Instead of harcoding the name to be main, we can parse the Cargo.toml file to check what is the name of the benchmarks.
We need to look for the bench target in Cargo.toml:

[[bench]]
name = "main"
@andreeaflorescu andreeaflorescu added the good first issue Good for newcomers label Sep 1, 2020
@iaGuoZhi
Copy link

iaGuoZhi commented Apr 6, 2022

Working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants