Replace more casts with safer conversions & enable cast-related lints. #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
changed the title
briansmith
force-pushed
the
b/casts-3-2
branch
3 times, most recently
from
d29aa27
to
125a3e6
Compare
briansmith
commented
Jun 1, 2024
briansmith
force-pushed
the
b/casts-3-2
branch
2 times, most recently
from
d9b4a3a
to
90b24d4
Compare
|
I have rebased this on top of #447 and extended it to address additional Clippy feedback from that change. |
briansmith
force-pushed
the
b/casts-3-2
branch
13 times, most recently
from
f331ab0
to
67f3bd5
Compare
briansmith
force-pushed
the
b/casts-3-2
branch
2 times, most recently
from
4008b07
to
7a89e48
Compare
usize and u32 both implement `From<u16>` so use u16 for the length.
josephlr
reviewed
Jun 21, 2024
Comment on lines
+211
to
+225
| #![deny( | ||
| clippy::cast_lossless, | ||
| clippy::cast_possible_truncation, | ||
| clippy::cast_possible_wrap, | ||
| clippy::cast_precision_loss, | ||
| clippy::cast_ptr_alignment, | ||
| clippy::cast_sign_loss, | ||
| clippy::char_lit_as_u8, | ||
| clippy::checked_conversions, | ||
| clippy::fn_to_numeric_cast, | ||
| clippy::fn_to_numeric_cast_with_truncation, | ||
| clippy::ptr_as_ptr, | ||
| clippy::unnecessary_cast, | ||
| clippy::useless_conversion | ||
| )] |
There was a problem hiding this comment.
Would it be possible to deny entire categories of lints (pedantic, correctness, complexity, etc...) rather than specific ones?
There was a problem hiding this comment.
Also, with the number of additional lints it may be better to enable them in clippy.toml.
briansmith
force-pushed
the
b/casts-3-2
branch
2 times, most recently
from
d06067f
to
4f8d78d
Compare
newpavlov
reviewed
Jun 21, 2024
| @@ -27,7 +27,9 @@ pub fn getrandom_inner(dest: &mut [MaybeUninit<u8>]) -> Result<(), Error> { | |||
| // Prevent overflow of u32 | |||
| let chunk_size = usize::try_from(i32::MAX).expect("Windows does not support 16-bit targets"); | |||
| for chunk in dest.chunks_mut(chunk_size) { | |||
| let ret = unsafe { RtlGenRandom(chunk.as_mut_ptr().cast::<c_void>(), chunk.len() as u32) }; | |||
| #[allow(clippy::cast_possible_truncation)] | |||
| let chunk_len = chunk.len() as u32; | |||
There was a problem hiding this comment.
You can write it as chunk.len().try_into().expect("chunk size is bounded by i32::MAX"). Compiler is able to properly remove such panic.
| // The chunk can be smaller than buf's length, so we call to | ||
| // JS to create a smaller view of buf without allocation. | ||
| #[allow(clippy::cast_possible_truncation)] |
There was a problem hiding this comment.
You can use .try_into().expect("..") here same as in windows7.
|
Closing in favor of #510. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.