-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating guide for Rand 0.8 #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Of course, we're not done yet with 0.8 so should probably wait off merging.
Several comments refer to rand_distr
changes, so I suppose we should mention the version numbers for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I added comments about the new |
Can we mention rust-random/getrandom#178 and rust-random/getrandom#177? They aren't merged yet but whether or not v0.2.1 is out before rand v0.8, we should mention it here. |
I'll merge now; we can make a new PR for any fixes. |
This is a first draft. It could be improved by adding external links (to
num_traits
andstd
).