Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cfg related warnings #485

Merged
merged 2 commits into from
May 20, 2024
Merged

fix cfg related warnings #485

merged 2 commits into from
May 20, 2024

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented May 19, 2024

This PR fixes some warnings that are currently blocking CI.

Freax13 added 2 commits May 19, 2024 17:57
@Freax13
remove mention of doc_cfg feature
29bdd0f 
`doc_cfg` has been superseded by `doc_auto_cfg`.
@Freax13
allow cfg(kani)
04b4c14 
Recently, rustc has started checking cfg expressions and so we have to
tell it explicitly that cfg(kani) is allowed because it has no way of
figuring that out itself.
@Freax13 Freax13 requested review from phil-opp and josephlr May 19, 2024 16:01
josephlr
josephlr approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I'm glad they added a way to fix the unexpected_cfgs lint without adding/changing a build script.

@josephlr josephlr merged commit 5aff621 into rust-osdev:master May 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr approved these changes

@phil-opp phil-opp Awaiting requested review from phil-opp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freax13 @josephlr