Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose DEBUG_STR more directly #471

Merged
merged 1 commit into from
Mar 18, 2024
Merged

expose DEBUG_STR more directly #471

merged 1 commit into from
Mar 18, 2024

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Mar 18, 2024

The constant is Sealed::DEBUG_STR was also already exposed to users in its subtraits, but due to Sealed being unnamable reading DEBUG_STR was somewhat difficult. Moving the associated constants from the supertrait into the subtraits isn't a breaking change and makes it a bit more convenient to reference.

Fixes #470

The constant is Sealed::DEBUG_STR was also already exposed to users
in its subtraits, but due to Sealed being unnamable reading DEBUG_STR
was somewhat difficult. Moving the associated constants from the
supertrait into the subtraits isn't a breaking change and makes it a
bit more convenient to reference.
@Freax13 Freax13 requested review from phil-opp and josephlr March 18, 2024 14:52
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Freax13 Freax13 merged commit 115f0e4 into master Mar 18, 2024
12 checks passed
@Freax13 Freax13 deleted the fix/expose-debug-str branch March 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sealed::DEBUG_STR is publicly accessible
2 participants