Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove external assembly #343

Merged
merged 4 commits into from
Feb 25, 2022
Merged

Remove external assembly #343

merged 4 commits into from
Feb 25, 2022

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Feb 24, 2022

Rust 1.59 was released today and inline assembly is now stable. This pr removes all uses of external assembly. It doesn't remove the external_asm and inline_asm features as that would be a breaking change.

@Freax13 Freax13 requested a review from phil-opp February 24, 2022 18:38
phil-opp
phil-opp approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

src/instructions/interrupts.rs Outdated Show resolved Hide resolved
src/instructions/mod.rs Outdated Show resolved Hide resolved
src/registers/mod.rs Outdated Show resolved Hide resolved
@Freax13 Freax13 requested a review from phil-opp February 25, 2022 08:06
phil-opp
phil-opp approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Maybe you could add a small comment to the inline_asm and external_asm features in the Cargo.toml, stating that they are now unused and only there for backwards compatibility. We should also remove these features on the next branch.

@Freax13 Freax13 requested a review from phil-opp February 25, 2022 11:52
@phil-opp phil-opp changed the title deprecate external_asm feature flag Remove external assembly Feb 25, 2022
@phil-opp phil-opp merged commit a143355 into rust-osdev:master Feb 25, 2022
@Freax13 Freax13 deleted the remove-extern-asm branch February 25, 2022 12:07
This was referenced Feb 25, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freax13 @phil-opp