Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an immutable getter for the level 4 page table #327

Merged
merged 1 commit into from
Dec 5, 2021
Merged

add an immutable getter for the level 4 page table #327

merged 1 commit into from
Dec 5, 2021

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Dec 2, 2021

This pr adds immutable getters for the level 4 page tables. It also appends the _mut suffix to the already existing getters.

Related to #325

@Freax13 Freax13 requested a review from phil-opp December 2, 2021 21:04
@Freax13 Freax13 mentioned this pull request Dec 2, 2021
Closed
phil-opp
phil-opp approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Freax13 Freax13 merged commit 0dd0f56 into rust-osdev:next Dec 5, 2021
@Freax13 Freax13 deleted the page-table-getter branch December 5, 2021 15:27
phil-opp added a commit that referenced this pull request Feb 3, 2022
@phil-opp
The level_4_table function only returns an immutable reference since …
b820a2e 
…#327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freax13 @phil-opp