Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activate feature(asm_const) #320

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Nov 8, 2021

CI is failing because yesterdays nightly release broke const operands in asm (see rust-lang/rust#90348). They now require #![feature(asm_const)]. Luckily we only use those on the next branch, so the master branch and all releases on crates.io should be fine.

This pr activates the asm_const feature when inline_asm is enabled.

Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You should be able to merge this yourself now.

@Freax13 Freax13 merged commit 37f8b0d into rust-osdev:next Nov 8, 2021
@Freax13 Freax13 deleted the fix-asm-const-operands branch November 8, 2021 10:40
@phil-opp phil-opp changed the title activate feature(abi_x86_interrupt) activate feature(asm_const) Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants