Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mapper): expose MapperFlush(All)?::new #296

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

toku-sa-n
Copy link
Member

It looks like there is no way to create an instance of these types.

Fixes: #295

@josephlr
Copy link
Contributor

josephlr commented Aug 20, 2021

I think this PR can be closed per #295 (comment)

EDIT: I was wrong, this change is reasonable.

@josephlr
Copy link
Contributor

@toku-sa-n you should also rebase this on latest master, that should fix an CI issues.

@toku-sa-n toku-sa-n force-pushed the flush_new branch 2 times, most recently from 5bd59af to f179d21 Compare August 29, 2021 02:17
It looks like there is no way to create an instance of these types.

Fixes: rust-osdev#295
@josephlr josephlr enabled auto-merge August 29, 2021 02:54
@josephlr josephlr merged commit 4ced281 into rust-osdev:master Aug 29, 2021
@toku-sa-n toku-sa-n deleted the flush_new branch August 29, 2021 02:57
@phil-opp phil-opp mentioned this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to create an instance of MapperFlush?
2 participants