feat(idt): make it available in the stable Rust #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
reviewed
Jun 27, 2021
`Entry::set_handler_addr`.
To prevent users from constructing these types.
josephlr
approved these changes
Jun 27, 2021
|
I'll give @phil-opp a chance to look over this, but LGTM on my end. |
phil-opp
approved these changes
Jun 27, 2021
There was a problem hiding this comment.
I left a few suggestions for the docs, but otherwise this looks good to me. Thanks, @toku-sa-n!
Co-authored-by: Philipp Oppermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
idtmodule available for use in the stable Rust with theinstructionsfeature.Especially, this PR
Entry::set_handler_addras an unsafe method. This is the only way for the users of this crate who build it with the stable Rust to set the addresses of the interrupt or exception handlers.()if theabi_x86_interruptfeature is not enabled. These types are only used with theabi_x86_interruptfeature.