Looser trait bounds for Port types #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in changes from upstream
dbeckwith
changed the title
|
Looks good to me, thank you! Let me know if I should merge this or if we should resolve #248 first. |
|
You can merge this, I'll deal with the conflicts. Thanks! |
phil-opp
added a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
#[derive(Debug, Clone, PartialEq, Eq)]on the genericPort<T>types creates a bound onTwhich isn't necessary because the struct does not contain any values of typeT. This isn't usually a problem because the only useful options forT(u8,u16, andu32) already implement these traits, but it can make it more annoying when working with other code that's generic over the port data type because you have to include these bounds. To fix this, I've manually implemented these traits without any bounds onT.