Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PhysToVirt trait to PageTableFrameMapping #214

Merged
merged 2 commits into from
Dec 28, 2020
Merged

Conversation

phil-opp
Copy link
Member

The new trait and method names better describe their purpose. Since the implementer must make sure that the returned pointer is valid and accessible, the trait is now unsafe to implement. Because of this requirement we also need to remove the generic implementation of this trait for closures.

(See #213 for an alternative, but unsuccessful, attempt).

@phil-opp phil-opp mentioned this pull request Dec 28, 2020
14 tasks
@phil-opp phil-opp changed the title Replace PhysToVirt with new PageTableFrameMapping trait Rename PhysToVirt trait to PageTableFrameMapping Dec 28, 2020
The new trait and method names better describe their purpose. Since the implementer must make sure that the returned pointer is valid and accessible, the trait is now unsafe to implement. Because of this requirement we also need to remove the generic implementation of this trait for closures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant