GDT: Add load_unchecked, from_raw_slice, and as_raw_slice.
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mental32
changed the title
load_unchecked, from_raw_parts, and into_raw_parts.load_unchecked, from_raw_parts, and into_raw_parts.
phil-opp
reviewed
Dec 28, 2020
phil-opp
added
the
waiting-on-author
phil-opp
reviewed
Dec 28, 2020
|
CI builds for stable are failing for |
phil-opp
reviewed
Dec 28, 2020
Co-authored-by: Philipp Oppermann <[email protected]>
|
Thanks a lot! |
phil-opp
approved these changes
Dec 28, 2020
phil-opp
changed the title
load_unchecked, from_raw_parts, and into_raw_parts.load_unchecked, from_raw_slice, and as_raw_slice.
phil-opp
added a commit
that referenced
this pull request
Dec 28, 2020
Merged
phil-opp
removed
the
waiting-on-author
This was referenced Mar 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the API for
structures::GlobalDescriptorTablefeels like it requires you to either:static mutto store your GDT (which is a bad idea)That's because there's no way to actually form your GDT entries without using
add_entrywhich takes&mut self... which seems contradictory thatloadrequires the GDT to be&'static self!you can get around this using a lazy_static of course but what if I want to use once_cell instead? there's no nice way of going about this... that's why this PR inroduces
load_uncheckedwhich is the same asloadwithout the'staticrequirement and markedunsafe(of course.)Also I noticed that sometimes you just know ahead of time what you want your GDT to be initialized with which lead me to add the const unsafe
from_raw_partsconstructor andinto_raw_parts.