Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VirtAddr::is_null #180

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Add VirtAddr::is_null #180

merged 1 commit into from
Sep 23, 2020

Conversation

toku-sa-n
Copy link
Member

Dereferencing to virtual address 0 is prohibited. This method is useful to prevent that.

@toku-sa-n toku-sa-n changed the title Add Virtaddr::is_null Add VirtAddr::is_null Sep 20, 2020
phil-opp
phil-opp approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will merge as soon as a new Rust nightly with a fixed rust-lld is out (so that the CI becomes green again).

@josephlr
Copy link
Contributor

Looks good to me! Will merge as soon as a new Rust nightly with a fixed rust-lld is out (so that the CI becomes green again).

It looks like the issue is fixed (judging by #181), so you if you resync. The tests should pass.

@phil-opp
Copy link
Member

Thanks for the ping!

@phil-opp phil-opp merged commit bfd0709 into rust-osdev:master Sep 23, 2020
@toku-sa-n toku-sa-n deleted the add_is_none_for_virt_address branch September 23, 2020 07:23
phil-opp added a commit that referenced this pull request Sep 23, 2020
@phil-opp
Update changelog for #180
e3c7726
@phil-opp
Copy link
Member

Published as v0.11.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toku-sa-n @josephlr @phil-opp