Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCID support instructions #169

Merged
merged 6 commits into from
Dec 29, 2020
Merged

PCID support instructions #169

merged 6 commits into from
Dec 29, 2020

Conversation

vinaychandra
Copy link
Contributor

  • Add CR3 support for PCID
  • Add invpcid instruction to flush TLB

@vinaychandra
Copy link
Contributor Author

@phil-opp can you please carefully review the assembly usage and comment as needed.

@vinaychandra
Copy link
Contributor Author

@phil-opp Ping!

phil-opp
phil-opp reviewed Jul 29, 2020
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! I was a bit busy the past weeks.

I left a few comments about things that could be improved in my opinion, but otherwise this looks good to me. Thanks!

src/registers/control.rs Outdated Show resolved Hide resolved
src/registers/control.rs Outdated Show resolved Hide resolved
src/asm/asm.s Show resolved Hide resolved
src/instructions/tlb.rs Outdated Show resolved Hide resolved
src/instructions/tlb.rs Outdated Show resolved Hide resolved
josephlr
josephlr reviewed Sep 23, 2020
View reviewed changes
src/instructions/tlb.rs Outdated Show resolved Hide resolved
src/instructions/tlb.rs Outdated Show resolved Hide resolved
src/instructions/tlb.rs Outdated Show resolved Hide resolved
src/registers/control.rs Outdated Show resolved Hide resolved
src/registers/control.rs Outdated Show resolved Hide resolved
src/registers/control.rs Show resolved Hide resolved
src/registers/control.rs Outdated Show resolved Hide resolved
src/registers/control.rs Outdated Show resolved Hide resolved
src/instructions/tlb.rs Outdated Show resolved Hide resolved
src/asm/asm.s Show resolved Hide resolved
@phil-opp
Copy link
Member

@vinaychandra Friendly ping :).

@phil-opp phil-opp added the waiting-on-author Waiting for the author to act on review feedback. label Dec 28, 2020
@vinaychandra
Copy link
Contributor Author

Thanks for the ping. Updated the PR

@phil-opp phil-opp added waiting-for-review Waiting for a review from the maintainers. and removed waiting-on-author Waiting for the author to act on review feedback. labels Dec 28, 2020
phil-opp
phil-opp reviewed Dec 28, 2020
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left one comment inline, otherwise this looks good to me.

src/instructions/tlb.rs Outdated Show resolved Hide resolved
@phil-opp phil-opp added waiting-on-author Waiting for the author to act on review feedback. and removed waiting-for-review Waiting for a review from the maintainers. labels Dec 28, 2020
@phil-opp phil-opp added waiting-for-review Waiting for a review from the maintainers. and removed waiting-on-author Waiting for the author to act on review feedback. labels Dec 29, 2020
@phil-opp phil-opp merged commit e16c098 into rust-osdev:master Dec 29, 2020
@phil-opp
Copy link
Member

Thanks!

@phil-opp phil-opp removed the waiting-for-review Waiting for a review from the maintainers. label Dec 29, 2020
phil-opp added a commit that referenced this pull request Dec 29, 2020
@phil-opp
Update changelog for #169
12c9c5f
@phil-opp
Copy link
Member

Published as v0.13.1

This was referenced Mar 17, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr left review comments

@phil-opp phil-opp phil-opp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinaychandra @phil-opp @josephlr