New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minimal scoped permissions to github workflow #411

Closed

joycebrum opened this issue Mar 17, 2023 · 1 comment · Fixed by #412

Contributor

joycebrum commented Mar 17, 2023

I would like to suggest to x86_64 project to adopt minimally scoped permissions on the github workflows.

I've made a similar change to the Volatile project rust-osdev/volatile#32.

The reason to do that is to avoid the default github workflow behavior of granting write all permission to all workflows.

I'll submit a PR together with this issue. Let me know any questions or concerns you might have.

joycebrum mentioned this issue

Set permissions to github workflows #412

Merged

josephlr closed this as completed in #412

Contributor

josephlr commented Mar 17, 2023

@phil-opp we should also update the default permissions for either this repo or the entire rust-osdev organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment