Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalDescriptorTable::add_entry creates SegmentSelector with hard coded privilege level #120

Closed
haraldh opened this issue Jan 24, 2020 · 3 comments

Comments

@haraldh
Copy link
Contributor

haraldh commented Jan 24, 2020

SegmentSelector::new(index as u16, PrivilegeLevel::Ring0)

Why is the privilege level hard coded?

@phil-opp
Copy link
Member

Good question… I think the idea was to set the requested privilege level to Ring0 by default so that all allowed segments can be accessed with the descriptor. However, I'm not sure about this anymore. What would be your preferred solution?

Independent of this, we should add a set_rpl method to the SegmentSelector type.

@phil-opp
Copy link
Member

Independent of this, we should add a set_rpl method to the SegmentSelector type.

This was added as part of #119. So now it is at least possible to change the RPL of a segment selector.

@haraldh
Copy link
Contributor Author

haraldh commented Jul 3, 2020

#153 fixed this .. thanks

@haraldh haraldh closed this as completed Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants