Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note about feature flags for uefi book #1168

Merged
merged 1 commit into from
May 17, 2024
Merged

Note about feature flags for uefi book #1168

merged 1 commit into from
May 17, 2024

Conversation

stillinbeta
Copy link
Contributor

@stillinbeta stillinbeta commented May 14, 2024 •
edited
Loading

It took me most of an evening to figure this out, so I thought I'd share it!

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

phip1611
phip1611 reviewed May 14, 2024
View reviewed changes
book/src/tutorial/app.md Outdated Show resolved Hide resolved
phip1611
phip1611 reviewed May 14, 2024
View reviewed changes
book/src/tutorial/app.md Outdated Show resolved Hide resolved
@phip1611
Copy link
Contributor

Sorry for the inconvenience you experienced. Great catch! I left some remarks.

@nicholasbishop I think we should expose all features except for unstable as default feature.

@nicholasbishop
Copy link
Member

@nicholasbishop I think we should expose all features except for unstable as default feature.

Sounds good to me.

@nicholasbishop nicholasbishop enabled auto-merge May 17, 2024 18:25
@nicholasbishop nicholasbishop mentioned this pull request May 17, 2024
Open
@nicholasbishop nicholasbishop added this pull request to the merge queue May 17, 2024
Merged via the queue into rust-osdev:main with commit 75ba438 May 17, 2024
12 checks passed
@nicholasbishop
Copy link
Member

Merged, thanks for taking the time to document this :)

Filed a followup ticket to set default features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 left review comments

@nicholasbishop nicholasbishop nicholasbishop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stillinbeta @phip1611 @nicholasbishop