Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-place variants of dimension-changing operations for dynamic-dimensional arrays #428

Open
jturner314 opened this issue Mar 19, 2018 · 2 comments

Comments

@jturner314
Copy link
Member

jturner314 commented Mar 19, 2018

The .remove_axis(), .insert_axis(), .into_subview(), and .slice_move() methods do not currently have in-place variants that change the number of dimensions, because for fixed-dimensionality arrays the type changes when changing the number of dimensions. However, dynamic-dimensional arrays do not have this limitation. It would be useful to have variants of these methods for dynamic-dimensional arrays that take &mut self instead of self as the argument.

See #425 for some discussion.

@bluss
Copy link
Member

bluss commented Mar 20, 2018

Thanks for filing these issues

@jturner314
Copy link
Member Author

jturner314 commented Mar 26, 2019

Status update:

  • .remove_axis() has been deprecated, and we shouldn't add an in-place variant of it.

  • .insert_axis_inplace() (in-place variant of .insert_axis()) was added in Rework subview methods and other related methods #537.

  • .index_axis_inplace() (in-place variant of .into_subview()) was added in Rework subview methods and other related methods #537.

  • So, the only one we're missing is an in-place variant of .slice_move(). We'll leave .slice_inplace() deprecated for a while, then remove it, then wait a while, then add .slice_inplace() for IxDyn arrays that removes axes like .slice_move() does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants