Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strongly typed strides #283

Open
bluss opened this issue Mar 25, 2017 · 7 comments
Open

Strongly typed strides #283

bluss opened this issue Mar 25, 2017 · 7 comments
Assignees

Comments

@bluss
Copy link
Member

bluss commented Mar 25, 2017

  • Separate type for D: Dimension and its corresponding stride
  • Strides are signed integers (isize)
@bluss bluss self-assigned this Mar 25, 2017
@Robbepop
Copy link
Contributor

I like this refactoring!
Personally I was slightly confused about this when scanning through the source code of ndarray.

@bluss
Copy link
Member Author

bluss commented Mar 28, 2017

It does keep it simple, less generics noise and repetition. However it is time..

@bluss
Copy link
Member Author

bluss commented Apr 9, 2017

Postponed to after 0.9. Potentially we want a bigger reorganization of Dimensions

@Robbepop
Copy link
Contributor

Robbepop commented Apr 9, 2017

Good decision - 0.9 is already pretty big!

@bluss
Copy link
Member Author

bluss commented Apr 9, 2017

Yeah; I don't know how I found so many technically breaking changes to add. There will always be intensive and not so intensive periods.

@Robbepop
Copy link
Contributor

Robbepop commented Apr 9, 2017

Yes, but I personally really like the way you handle refactoring of code and breaking changes in your projects. You do not fear them, you approach them and simply introduce all those new shiny features instead of going with an overly conservative approach that avoids to ever break anything which sadly is a strategy in a few crates ... 👍
But who am I to judge. ;)

@bluss
Copy link
Member Author

bluss commented Apr 10, 2017

In this case they have been many technically breaking but almost no actual effect on end users. All changes are judged for their effect, not the technically breaking status. Which is why it is hard to change how dimensions work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants