ndk-glue: Switch to parking_lot
for map
pable and Send
able lock guards
#282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #282
It has come up previously that the
native_window()
function is easier to use if we could transpose aLockGuard<Option<>>
into anOption<LockGuard<>>
. After all, as soon as you have the lock you only need to check theOption<>
value once and are thereafter guaranteed that its value won't change, until the lock is given up.At the same time
parking_lot
has asend_guard
feature which allows moving a lock guard to another thread (as long asdeadlock_detection
is disabled); a use case for this recently came up in glutin where theNativeWindow
handle lock should be stored with a GL context so that ourfn on_window_destroyed()
callback doesn't return until after theSurface
created on it is removed from the context and destroyed. Glutin forces this context to beSend
, and a lock guard already allowsSync
ifNativeWindow
isSync
(which it is).