Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias errors when used as @rustbot author: xxx #1560

Closed
fee1-dead opened this issue Jan 14, 2022 · 3 comments
Closed

Alias errors when used as @rustbot author: xxx #1560

fee1-dead opened this issue Jan 14, 2022 · 3 comments
Labels
A-command-parsing Area: command parsing A-shortcuts Area: Shortcut commands

Comments

@fee1-dead
Copy link
Member

Found in rust-lang/rust#92892 (comment), I wanted to write what exact parts are waiting on author so I wrote @rustbot author: xxx which caused an error.

@camelid
Copy link
Member

camelid commented Jan 14, 2022

FWIW, you can just write the explanation on a separate line, though I suspect you're opening this issue because you think the : style should be supported too :)

@ehuss ehuss added A-shortcuts Area: Shortcut commands A-command-parsing Area: command parsing labels Jul 20, 2023
@kusabana
Copy link

This does not appear to be an issue anymore.
Input tested on aa559cc (commit near issue date):

Err(
    Error {
        input: "author: please add a ui test for the issue, in `src/test/ui/consts`, or in `src/test/ui/rfc-2632-const-trait-impl`, after that the changes LGTM.",
        position: 6,
        source: ExpectedEnd,
    },
)

Input tested on 9ea655c (current master):

Ok(
    Some(
        Author,
    ),
)

@ehuss
Copy link
Contributor

ehuss commented Sep 16, 2023

Indeed, I believe this is fixed by #1640, thanks!

@ehuss ehuss closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-command-parsing Area: command parsing A-shortcuts Area: Shortcut commands
Projects
None yet
Development

No branches or pull requests

4 participants