-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rustup-mode): install the active toolchain by default on rustup toolchain install
#3983
Conversation
c8da02e
to
f9bff67
Compare
f9bff67
to
cf4dd59
Compare
… toolchain install`
cf4dd59
to
261b851
Compare
I think conceptually it would be a good next step to break |
@djc The whole story is actually more complex than that. We already have My plan is that when removing implicit installations altogether, this new call site of that |
Is there documentation of the new |
While not really in the same situation, here is the background of why Cargo moved away from implicit |
Hm, I think rustup is kinda in the exact opposite position. As that issue says, you (almost) never want to |
@ChrisDenton This PR has already changed the |
I was thinking more of online documentation. Although maybe that should wait until a release. Something along the lines of advice for people using CI. Because presumably we want to guide people towards using this rather than relying on auto install as a side effect of other commands. |
@ChrisDenton The plan is to get rid of implicit installations immediately (#3985), and I promise that will be mentioned in highlight when we cut a new release 🙏 |
Closes #2686 by extending the existing
rustup toolchain install
andrustup install
commands, as discussed in #3635 (comment):TLDR: This PR makes
rustup toolchain install
andrustup install
install the active toolchain, i.e. behave like the hypotheticalrustup toolchain ensure
command, when no toolchain is specified.