Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building rustup for Windows arm64 #2835

Merged
merged 4 commits into from
Sep 4, 2021
Merged

Support building rustup for Windows arm64 #2835

merged 4 commits into from
Sep 4, 2021

Conversation

Alovchin91
Copy link
Contributor

This PR adds support for building rustup for Windows arm64 using aarch64-pc-windows-msvc toolchain.

Things to note:

See #2612 for discussion

@Alovchin91
Copy link
Contributor Author

Test results: (see attachments)

All run under rustc 1.55.0-beta.3 (53fd98ca7 2021-07-31) installed by that same arm64 rustup 🙂

Note: for download tests I had to manually remove rustls-tls (requires ring) from Cargo.toml default features because cargo test doesn't seem to respect --no-default-features/--features flags when passed a -p parameter.

dump_testament.txt
cargo_test.txt
download_test.txt

@Alovchin91 Alovchin91 marked this pull request as ready for review August 4, 2021 22:58
@kinnison
Copy link
Contributor

kinnison commented Aug 9, 2021

When you updated the CI actions, did you update the template and then run the script to regenerate the workflow files? If so then I need to poke the scripts. Otherwise this PR looks good. I'll check that over and then consider merging.

@Alovchin91
Copy link
Contributor Author

When you updated the CI actions, did you update the template and then run the script to regenerate the workflow files?

Yep, that's what I did. Apparently I also need to mark those parameters in the "include" section with "skip-pr skip-master" otherwise they seem to be picked up by the CI.

@kinnison
Copy link
Contributor

kinnison commented Aug 9, 2021

I think you must be right - it is over-executing on PRs for sure. Try adding the markers to the include section too please, yes.

@Alovchin91
Copy link
Contributor Author

Sure! Do you think it makes sense to disable win-arm64 builds for now (since we seem to be making some good progress on *ring*: briansmith/ring#1339), or should we still enable them for stable or master, for example?

@kinnison
Copy link
Contributor

kinnison commented Aug 9, 2021

I'm not sure if we're OK to release until ring is sorted, as such let's build on master, but not pr or stable.

@Alovchin91
Copy link
Contributor Author

👍 Done. Also updated the README.

@Alovchin91
Copy link
Contributor Author

Hi @kinnison Do you think this could be merged now? 🙂

@kinnison kinnison merged commit 52376ff into rust-lang:master Sep 4, 2021
@Alovchin91 Alovchin91 deleted the alovchin91/win-arm64 branch September 4, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants