-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building rustup for Windows arm64 #2835
Conversation
Test results: (see attachments) All run under rustc 1.55.0-beta.3 (53fd98ca7 2021-07-31) installed by that same arm64 rustup 🙂 Note: for download tests I had to manually remove rustls-tls (requires ring) from Cargo.toml default features because cargo test doesn't seem to respect --no-default-features/--features flags when passed a -p parameter. |
When you updated the CI actions, did you update the template and then run the script to regenerate the workflow files? If so then I need to poke the scripts. Otherwise this PR looks good. I'll check that over and then consider merging. |
Yep, that's what I did. Apparently I also need to mark those parameters in the "include" section with "skip-pr skip-master" otherwise they seem to be picked up by the CI. |
I think you must be right - it is over-executing on PRs for sure. Try adding the markers to the include section too please, yes. |
Sure! Do you think it makes sense to disable win-arm64 builds for now (since we seem to be making some good progress on *ring*: briansmith/ring#1339), or should we still enable them for stable or master, for example? |
I'm not sure if we're OK to release until ring is sorted, as such let's build on master, but not pr or stable. |
👍 Done. Also updated the README. |
Hi @kinnison Do you think this could be merged now? 🙂 |
This PR adds support for building rustup for Windows arm64 using aarch64-pc-windows-msvc toolchain.
Things to note:
See #2612 for discussion