-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD CI failure possibly caused by rustls-platform-verifier
#3908
Comments
Originally posted by @djc in #3903 (comment) |
@djc In #3903 |
Right, that's a pretty limited dependency: [target.'cfg(target_arch = "wasm32")'.dependencies]
webpki-roots = "0.26"
# BSD targets require webpki-roots for the real-world verification tests.
[target.'cfg(target_os = "freebsd")'.dev-dependencies]
webpki-roots = "0.26" But my point was, before #3903 we were using |
@djc I see what you mean now. This is very weird... Before (d85502c): > cargo tree -i webpki-roots --target=x86_64-unknown-freebsd
error: package ID specification `webpki-roots` did not match any packages
> cargo tree -i rustls-native-certs --target=x86_64-unknown-freebsd
rustls-native-certs v0.7.0
└── reqwest v0.12.4
└── download v1.27.1
└── rustup v1.27.1 After (f48df22): > cargo tree -i webpki-roots --target=x86_64-unknown-freebsd
warning: nothing to print.
> cargo tree -i rustls-native-certs --target=x86_64-unknown-freebsd
rustls-native-certs v0.7.0
└── rustls-platform-verifier v0.3.1
└── download v1.27.1
└── rustup v1.27.1 Could it be that these two dependencies (reqwest and rustls-platform-verifier) are using rustls-native-certs slightly differently? |
Indeed, both are using the following snippet, but rustls-platform-verifier is using it under a guard only, and that guard is disabled on FreeBSD. #[cfg(feature = "rustls-tls-native-roots")]
[..]
for cert in rustls_native_certs::load_native_certs() #[cfg(all(target_os = "linux", not(target_arch = "wasm32")))]
match rustls_native_certs::load_native_certs() { |
As the upstream issue has been resolved in rustls/rustls-platform-verifier#105, there's no point tracking it here for any longer (the problem will definitely go away before the next release since there will be at least some dep version bumps before then). |
@djc Unfortunately, #3903 has seemingly broken our FreeBSD CI:
I have completely no idea why that is the case. Doesn't look like a network problem either: a few minutes ago there was another FreeBSD test and it passed; a few minutes later there was a third FreeBSD test and it failed.
I'm not sure what this
DecodeError
is. Could it beX.509
-related?The text was updated successfully, but these errors were encountered: