Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream a bug fix for platform detection on MacOS #3419

Closed
davidanthoff opened this issue Jul 27, 2023 · 3 comments · Fixed by #3438
Closed

Upstream a bug fix for platform detection on MacOS #3419

davidanthoff opened this issue Jul 27, 2023 · 3 comments · Fixed by #3438

Comments

@davidanthoff
Copy link

The Julia programming language has a tool Juliaup which was not only heavily inspired by rustup, but I also copied the rustup-init.sh script as a starting point. First of all: thanks so much for an awesome project, the inspiration and the code, it made building Juliaup sooo much easier!

We recently fixed a pretty bizzar corner case bug with the shell script re platform detection, and I just thought I'd let you know in case you want to copy that over into your rustup-init.sh :) The PR is JuliaLang/juliaup#701.

@StefanKarpinski
Copy link

Might be nice to factor some of the gnarly platform-detection functionality into a separate file that can be shared between the languages so that fixes are easier to share, but maybe would add too much overhead.

@rbtcollins
Copy link
Contributor

This would be great to turn into a PR - thank you!

@rbtcollins
Copy link
Contributor

@davidanthoff thank you for this - you might want to see our diff - we found additional corner cases in the approach in your patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants