Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup should handle running RLS when the default toolchain is stable #1083

Closed
KalitaAlexey opened this issue Apr 22, 2017 · 4 comments
Closed

Comments

@KalitaAlexey
Copy link

Hello everyone.

Since only nightly has the component RLS, one should either use nightly or use stable, but not use RLS.

I suppose rustup should handle the following case:

Setup

I have two toolchains: stable, nightly.
I installed the component RLS for the nightly toolchain.
I made the stable toolchain be my default.

Action

I run rls

Excepted result

rustup runs RLS from the nightly toolchain.

Actual result

rustup says RLS is not installed for stable.

What do you think about it?

@Diggsey
Copy link
Contributor

Diggsey commented Apr 22, 2017

What happens when rls lands on stable?

@KalitaAlexey
Copy link
Author

Remove the approach and that's all.

@Diggsey
Copy link
Contributor

Diggsey commented Apr 28, 2017

I just don't think this is worthwhile, and is more likely to result in confusion. It would be too surprising to run programs from a different toolchain that the one that is active.

You can always use rls +nightly while on a stable toolchain as workaround.

@Diggsey
Copy link
Contributor

Diggsey commented Apr 28, 2017

Also, rustup is not intended to be tied to specific rustc versions. I'm against changes that we know will have to be reverted in a later version.

@nrc nrc closed this as completed Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants