Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt-nightly 0.3.4 deleting from macro bodies #2344

Closed
cmdln opened this issue Jan 5, 2018 · 1 comment
Closed

rustfmt-nightly 0.3.4 deleting from macro bodies #2344

cmdln opened this issue Jan 5, 2018 · 1 comment

Comments

@cmdln
Copy link

cmdln commented Jan 5, 2018

I noticed the deprecation warning from rustfmt and install rustfmt-nightly 0.3.4. Seems to work well except it clobbers some of my macro bodies.

See https://gist.github.com/anonymous/893e7bf6b3e8b3841052098edc07c25e for an example.

Asked in the serde room in case this was something specific to the json macro. Looks like the issue is only reproduce-able when the result of the macro is assigned in a let statement. If the json! macro is passed into a function or used as a return expression in a block or function, rustfmt-nightly doesn't mangle the macro body.

@topecongiro
Copy link
Contributor

Closing as a duplicate of #2338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants