-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file_lines with a comment is broken #1159
Comments
Urg. I completely dropped this, didn't I? The implementation of the feature was never done after the initial PR. I'll try to take a look this week. |
Oh and what do you mean by "only bails from"? |
bails == early return (without doing any formatting) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this is because we lose the distinction between a statement and expression and file-lines only bails from statements, not expressions. Not exactly sure why, but we then get the wrong indents for comments. I couldn't find a fix for this, so I had to delete the comments from the file-lines tests.
cc @kamalmarhubi
The text was updated successfully, but these errors were encountered: