New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 92294 was flagged as "probably changed"; why not "Improvement" ? #1135

Closed

pnkfelix opened this issue Jan 4, 2022 · 3 comments

Member

pnkfelix commented Jan 4, 2022

PR: rust-lang/rust#92294

Perf results: https://perf.rust-lang.org/compare.html?start=4d2e0fd96ccbb9ade41f1a3f07b14b7437f8e4ef&end=c9cf9c65072a35585f9521ab95044f32d5fcb9ec

Maybe I'm missing something: Why isn't this flagged as "Improvement" ?

Member Author

pnkfelix commented Jan 4, 2022

Oh, is it because all the changes are less than 1%?

Member Author

pnkfelix commented Jan 4, 2022

I wonder similarly about rust-lang/rust#92314

Member

rylev commented Apr 11, 2022

We've gotten rid of the "probably changed" section, so this is no longer an issue.

rylev closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment