Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to "ask for another round of review" via rustbot labels #1123

Closed
RalfJung opened this issue May 5, 2021 · 2 comments · Fixed by #1124
Closed

Explain how to "ask for another round of review" via rustbot labels #1123

RalfJung opened this issue May 5, 2021 · 2 comments · Fixed by #1124

Comments

@RalfJung
Copy link
Member

RalfJung commented May 5, 2021

New contributors currently have no good way of knowing this magic incantation

@rustbot label -S-waiting-on-author +S-waiting-on-review

It should probably be mentioned somewhere on https://rustc-dev-guide.rust-lang.org/contributing.html.

See rust-lang/rust#82703 for a recent case where this came up (and I've certainly seen other instances of this before).

@iago-lito
Copy link

Well, now I have found it there, pointing there. The problem was that I was so busy figuring out the How to Build and Run the Compiler and the compiler testing framework back then that I did not make my way down to this section.

But now that I am mostly done with implementation, maybe I should've simply come back to this book earlier?

@RalfJung
Copy link
Member Author

RalfJung commented May 5, 2021

Ah, that also shows a good place to add the exact command. :) Opened #1124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants