Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #99157

Closed
wants to merge 19 commits into from
Closed

Rollup of 5 pull requests #99157

wants to merge 19 commits into from

Commits on Jul 8, 2022

  1. Move EarlyBinder calls in rustc_typeck::outlives a bit further up

    @jackh726
    jackh726 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    f165843 View commit details
    Browse the repository at this point in the history

  2. Add bound_const_param_default

    @jackh726
    jackh726 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    9935796 View commit details
    Browse the repository at this point in the history

  3. Use map_bound

    @jackh726
    jackh726 committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    ad9e1e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. Use constant eval to do strict validity checks

    @5225225
    5225225 committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    b361638 View commit details
    Browse the repository at this point in the history

  2. All init checks go through rustc_const_eval, cleanup

    @5225225
    5225225 committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    c84cfa4 View commit details
    Browse the repository at this point in the history

  3. Adjust docs on old might_permit_raw_init, cleanup

    @5225225
    5225225 committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    ab4a80e View commit details
    Browse the repository at this point in the history

  4. Cleanup, move might_permit_raw_init to own file

    @5225225
    5225225 committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    b398fa5 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2022

  1. check non_exhaustive attr and private fields for transparent types

    @fee1-dead
    fee1-dead committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    fc26ca1 View commit details
    Browse the repository at this point in the history

  2. add more tests

    @fee1-dead
    fee1-dead committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    5fb6784 View commit details
    Browse the repository at this point in the history

  3. Fix sized check ICE in intrisicck

    @compiler-errors
    compiler-errors committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    3ac69d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. fix(doctest): treat fatal parse errors as incomplete attributes 

    Fixes rust-lang#99089
    @notriddle
    notriddle committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    6c44357 View commit details
    Browse the repository at this point in the history

  2. Cleanup not needed arguments

    @5225225
    5225225 committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    b7c1868 View commit details
    Browse the repository at this point in the history

  3. Add test for uninit value with validity invariant in array

    @5225225
    5225225 committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    236c7c0 View commit details
    Browse the repository at this point in the history

  4. placeholders -> inference vars in comment

    @jackh726
    jackh726 authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    988e754 View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#99020 - fee1-dead-contrib:repr_transparent_… 

    …non_exhaustive, r=oli-obk

check non_exhaustive attr and private fields for transparent types

Fixes rust-lang#78586.
    @Dylan-DPC
    Dylan-DPC authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    a93152d View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#99033 - 5225225:interpreter-validity-checks… 

    …, r=oli-obk

Use constant eval to do strict mem::uninit/zeroed validity checks

I'm not sure about the code organisation here, I just dumped the check in rustc_const_eval at the root. Not hard to move it elsewhere, in any case.

Also, this means cranelift codegen intrinsics lose the strict checks, since they don't seem to depend on rustc_const_eval, and I didn't see a point in keeping around two copies.

I also left comments in the is_zero_valid methods about "uhhh help how do i do this", those apply to both methods equally.

Also rustc_codegen_ssa now depends on rustc_const_eval... is this okay?

Pinging `@RalfJung` since you were the one who mentioned this to me, so I'm assuming you're interested.

Haven't had a chance to run full tests on this since it's really warm, and it's 1AM, I'll check out any failures/comments in the morning :)
    @Dylan-DPC
    Dylan-DPC authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    3f66c4e View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#99038 - jackh726:earlybinder-cleanup, r=lcnr 

    Some more `EarlyBinder` cleanups

First commit has a couple unrelated cleanups, but otherwise each commit is self-explanatory

r? rust-lang/types
    @Dylan-DPC
    Dylan-DPC authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    542d036 View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#99124 - compiler-errors:issue-99122, r=oli-obk 

    Fix sized check ICE in asm check

Fixes (beta nominated, so doesn't close) rust-lang#99122
    @Dylan-DPC
    Dylan-DPC authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    db4e980 View commit details
    Browse the repository at this point in the history

  9. Rollup merge of rust-lang#99142 - notriddle:notriddle/doctest-multili… 

    …ne-crate-attributes, r=GuillaumeGomez

fix(doctest): treat fatal parse errors as incomplete attributes

Fixes rust-lang#99089
    @Dylan-DPC
    Dylan-DPC authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    18a2fa7 View commit details
    Browse the repository at this point in the history