Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Miri #98698

Merged
merged 1 commit into from
Jun 30, 2022
Merged

update Miri #98698

merged 1 commit into from
Jun 30, 2022

Conversation

RalfJung
Copy link
Member

Fixes #98599
r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2022

Some changes occurred in src/tools/miri

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jun 30, 2022

📌 Commit 4355199 has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 30, 2022
@bors
Copy link
Contributor

bors commented Jun 30, 2022

⌛ Testing commit 4355199 with merge 7b68106...

@bors
Copy link
Contributor

bors commented Jun 30, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 7b68106 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 30, 2022
@bors bors merged commit 7b68106 into rust-lang:master Jun 30, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 30, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #98698!

Tested on commit 7b68106.
Direct link to PR: #98698

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 30, 2022
Tested on commit rust-lang/rust@7b68106.
Direct link to PR: <rust-lang/rust#98698>

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk).
@RalfJung RalfJung deleted the miri branch June 30, 2022 14:34
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7b68106): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-1.5% -1.5% 2
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-3.3% -3.3% 1
Improvements 🎉
(secondary)
-3.2% -4.4% 3
All 😿🎉 (primary) -3.3% -3.3% 1

Cycles

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)
2.8% 3.3% 2
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) 2.8% 3.3% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@albertlarsan68 albertlarsan68 mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#98591
5 participants