Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move MIR syntax into a dedicated file and ping some people whenever it changes #98649

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

RalfJung
Copy link
Member

Adding or changing MIR operations/statements/whatever should be under significant scrutiny wrt their wider impact, specified semantics, and so on. So let's start by putting all that into a dedicated file and pinging some people whenever that file changes.

This PR only moves definitions around, and then fiddles with imports until it all works again.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 29, 2022
@rust-highfive
Copy link
Collaborator

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2022
@RalfJung RalfJung force-pushed the guardians-of-mir branch 2 times, most recently from 95f41bd to 418dfe2 Compare June 29, 2022 01:48
@RalfJung
Copy link
Member Author

Cc @lcnr @rust-lang/wg-mir-opt let me know if I should add more people (or teams) to the mention list here.

triagebot.toml Outdated Show resolved Hide resolved
@oli-obk
Copy link
Contributor

oli-obk commented Jun 29, 2022

@bors r+ p=1

let's move this along before it bitrots

@bors
Copy link
Contributor

bors commented Jun 29, 2022

📌 Commit ef34e57a74ec16d60ba9ccb958dfafaed57a1785 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2022
@bors
Copy link
Contributor

bors commented Jun 29, 2022

⌛ Testing commit ef34e57a74ec16d60ba9ccb958dfafaed57a1785 with merge f6b29fbf3c31d9c42872943e76037572f3cfb823...

@bors
Copy link
Contributor

bors commented Jun 29, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 29, 2022
@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member Author

Argh, sorry for that...

@RalfJung
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jun 29, 2022

📌 Commit a58d8f6 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2022
@bors
Copy link
Contributor

bors commented Jun 29, 2022

⌛ Testing commit a58d8f6 with merge 9789394f4f43d9bd711558bb04ecb084753e745c...

@bors
Copy link
Contributor

bors commented Jun 29, 2022

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 29, 2022
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2022
@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member Author

Still some rustdoc stuff...?

@RalfJung
Copy link
Member Author

RalfJung commented Jun 29, 2022

./x.py doc compiler/rustc_builtin_macros does not reproduce the error here.

I think I know how to fix this, but how can I check...?

EDIT: ah, it's in rustc_middle.

@RalfJung
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jun 29, 2022

📌 Commit 6c990f4 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2022
@bors
Copy link
Contributor

bors commented Jun 30, 2022

⌛ Testing commit 6c990f4 with merge a9eb9c5...

@bors
Copy link
Contributor

bors commented Jun 30, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing a9eb9c5 to master...

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a9eb9c5): comparison url.

Instruction count

  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
0.5% 0.5% 1
Regressions 😿
(secondary)
1.6% 4.3% 20
Improvements 🎉
(primary)
-0.3% -0.4% 5
Improvements 🎉
(secondary)
-0.3% -0.3% 3
All 😿🎉 (primary) -0.2% 0.5% 6

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
3.3% 4.4% 2
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-1.4% -1.4% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)
3.3% 3.3% 1
Regressions 😿
(secondary)
2.6% 2.6% 1
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) 3.3% 3.3% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@rustbot rustbot added the perf-regression Performance regression. label Jun 30, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a9eb9c5): comparison url.

Instruction count

  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
0.5% 0.5% 1
Regressions 😿
(secondary)
1.6% 4.3% 20
Improvements 🎉
(primary)
-0.3% -0.4% 5
Improvements 🎉
(secondary)
-0.3% -0.3% 3
All 😿🎉 (primary) -0.2% 0.5% 6

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
3.3% 4.4% 2
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-1.4% -1.4% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)
3.3% 3.3% 1
Regressions 😿
(secondary)
2.6% 2.6% 1
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) 3.3% 3.3% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@RalfJung
Copy link
Member Author

Oh, we're getting the news twice this time?^^

@Mark-Simulacrum Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Jul 5, 2022
@albertlarsan68 albertlarsan68 mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants