-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move MIR syntax into a dedicated file and ping some people whenever it changes #98649
Conversation
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
95f41bd
to
418dfe2
Compare
Cc @lcnr @rust-lang/wg-mir-opt let me know if I should add more people (or teams) to the mention list here. |
@bors r+ p=1 let's move this along before it bitrots |
📌 Commit ef34e57a74ec16d60ba9ccb958dfafaed57a1785 has been approved by |
⌛ Testing commit ef34e57a74ec16d60ba9ccb958dfafaed57a1785 with merge f6b29fbf3c31d9c42872943e76037572f3cfb823... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
Argh, sorry for that... |
Co-authored-by: David Wood <[email protected]>
ef34e57
to
a58d8f6
Compare
@bors r=oli-obk |
📌 Commit a58d8f6 has been approved by |
⌛ Testing commit a58d8f6 with merge 9789394f4f43d9bd711558bb04ecb084753e745c... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
Still some rustdoc stuff...? |
I think I know how to fix this, but how can I check...? EDIT: ah, it's in rustc_middle. |
@bors r=oli-obk |
📌 Commit 6c990f4 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a9eb9c5): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
Finished benchmarking commit (a9eb9c5): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
Oh, we're getting the news twice this time?^^ |
Adding or changing MIR operations/statements/whatever should be under significant scrutiny wrt their wider impact, specified semantics, and so on. So let's start by putting all that into a dedicated file and pinging some people whenever that file changes.
This PR only moves definitions around, and then fiddles with imports until it all works again.